search

mpolden / echoip

IP address lookup service
https://ifconfig.co
BSD 3-Clause "New" or "Revised" License
4.01k stars 526 forks source link

`Accept` header parsing is too strict. #147

Open kirelagin opened 2 years ago

kirelagin commented 2 years ago

Current implementation only recognises application/json, however the format of the Accept header is more flexible.

For example, the http client library that I am using is setting it to application/json;charset=utf-8,application/json and, as a result I am getting an HTML response. I worked this around by querying the /json endpoint for now.

Test:

$ curl -H 'User-Agent: something' -H 'Accept: application/json;charset=utf-8,application/json' http://ifconfig.co:80/
<!DOCTYPE html>
...