mpollmeier / gremlin-scala

[unmaintained] Scala wrapper for Apache TinkerPop 3 Graph DSL
Apache License 2.0
482 stars 76 forks source link

Scala 2.13 support #285

Closed To-om closed 5 years ago

To-om commented 5 years ago

Hi, Do you plan to crossbuild gremlin-scala for scala 2.13 ?

mpollmeier commented 5 years ago

yeah, just didn't get to it yet, life is too busy.

just tried simply upgrading a few deps - compile works, Test/compile needs some love. :crossed_fingers: we don't need to touch the macros

To-om commented 5 years ago

Scalamock has been released for 2.13. With this version, all gremlin-scala tests pass.

I don't know why but I had to add override def getSteps: util.List[Step[_, _]] = super.getSteps in TraversalStrategySpec > RemoteGraphFixture > new AbstractRemoteTraversal to make it work.

mpollmeier commented 5 years ago

Thanks for letting me know! And very strange indeed with the getSteps 'override'. will merge on green: https://github.com/mpollmeier/gremlin-scala/pull/286

mpollmeier commented 5 years ago

3.4.1.6 is released for scala 2.11, 2.12 and 2.13 :tada: