search

mpope9 / exor_filter

Erlang nif for xor_filter. 'Faster and Smaller Than Bloom and Cuckoo Filters'.
Apache License 2.0
31 stars 3 forks source link

Allow checking a binary filter without deserializing to a resource #11

Closed Vagabond closed 4 years ago

mpope9 commented 4 years ago

at first glance it looks like the resource usage of contain wouldn't work, but I could just be mistaken. I will take another look later in the week and give it a run. This addition is much appreciated.

Vagabond commented 4 years ago

It checks if its a resource, if it's not a resource it checks if its a binary and tries to populate the xor filter struct/fingerprints from the values in the binary. This definitely does work as I've done quite a lot of benchmarking with it.

mpope9 commented 4 years ago

My mistake, my cursory glace was wrong!

Vagabond commented 4 years ago

Any updates on this?

mpope9 commented 4 years ago

My mistake, have been distracted recently.