search

mpope9 / nba-sql

:basketball: An application to build an NBA database backed by MySQL, Postgres, or SQLite
Apache License 2.0
176 stars 20 forks source link

Get shots for specific season instead of all shots. #60

Closed mpope9 closed 2 years ago

mpope9 commented 2 years ago

OK, so the way shot_chart_detail is loaded can be simplified, potentially. Right now we fetch all shots for each player + team combo into a temp table. We then insert from the temp table into the main shot_chart_detail if the games exist. Instead, it'd be useful to try and fetch from the shotchartdetail API just for the games in the season. By also passing the GameID parameter.

The downside is that this could generate more requests and result in worse performance.

mpope9 commented 2 years ago

Not possible. https://github.com/mpope9/nba-sql/issues/63 as an alternative.