search

mpope9 / nba-sql

:basketball: An application to build an NBA database backed by MySQL, Postgres, or SQLite
Apache License 2.0
171 stars 20 forks source link

Fix for issue 78. #79

Closed pb-new-username closed 2 years ago

pb-new-username commented 2 years ago

Problem here is that the function create_ddl() for both, ShotChartDetailRequester and PlayerGameLogRequester attempt to create the temp tables ShotChartDetailTemp and PlayerGameLogTemp twice. Once inside the init functions and once inside the create_ddl functions. This PR simply removes code that creates the temp table from the create_ddl functions.

This is a fix for issue https://github.com/mpope9/nba-sql/issues/78

mpope9 commented 2 years ago

Sweet. I'll take this for a spin this evening.

mpope9 commented 2 years ago

Checked it out, running a test locally on a fresh DB. If it is populated by the morning I'll merge this.

mpope9 commented 2 years ago

Thank you v much for this fix! Great find