mpounsett / nagiosplugin

A Python class library which helps with writing Nagios (Icinga) compatible plugins.
https://nagiosplugin.readthedocs.io/
Other
28 stars 14 forks source link

Class Summary could be reimplemented as an actual Abstract Base Class #44

Open mpounsett opened 2 years ago

mpounsett commented 2 years ago

Linting complains about the signatures of several methods in this class (no-self-use), and the issue could be resolved by reimplementing them as @staticmethod methods, but that might be API-breaking if anyone is making use of self references in subclassed implementations. If these can't be @staticmethod then they could be reimplemented as a proper ABC using the @abstractmethod decorator.