mprahl / s2i-angular-httpd24

S2I Builder for Angular Apps Based on the Official CentOS and RHEL httpd-24 Images
MIT License
2 stars 14 forks source link

Enable incremental builds to keep node_modules #6

Closed ddelabru closed 4 years ago

ddelabru commented 5 years ago

I've tried making some slight changes to allow keeping node_modules for incremental builds.

I'm not recommending we merge this yet; I've been trying to test this in OpenShift but incremental builds always hang on the preliminary step of pulling the latest container image from the associated docker registry. I've got a build running right now that, according to the logs, has been pulling the image for twenty minutes. I'm a little stumped by it and wanted to open a PR in case there's anything glaringly wrong with it.