mpratt / Embera

A Oembed consumer library, that gives you information about urls. It helps you replace urls to youtube or vimeo for example, with their html embed code. It has advanced features like offline support, responsive embeds and caching support.
MIT License
335 stars 59 forks source link

fix: Token in unlisted Vimeo URLs being stripped by URL normalizer #105

Closed simshaun closed 5 months ago

simshaun commented 6 months ago

Hi,

Unlisted videos on Vimeo have a URL like https://vimeo.com/919781633/1a2b3c4d5e where 1a2b3c4d5e is what I refer to as the "privacy token".

(Note: I am unable to provide an actual unlisted video URL; I only have my client's which I cannot share. The example I gave above works with or without the token on the end. The actual unlisted video I have will not.)

The Vimeo provider is normalizing this to https://player.vimeo.com/video/919781633, effectively stripping the privacy token and preventing the OEmbed lookup from fetching information.

This PR makes the URL normalizer stricter, so it won't normalize URLs that have additional data after the video ID.

mpratt commented 5 months ago

Thanks for the PR!