Fix several issues - Githubissues

mpratt / Embera

A Oembed consumer library, that gives you information about urls. It helps you replace urls to youtube or vimeo for example, with their html embed code. It has advanced features like offline support, responsive embeds and caching support.

MIT License

335 stars 59 forks source link

Fix several issues #63

Closed vkhramtsov closed 4 years ago

vkhramtsov commented 4 years ago

[x] Remove obsolete use statements
[x] Fix php docs
[x] Remove array usage where we can use simple compare
[x] Optimize some code
[x] Remove methods with same body as in parent

vkhramtsov commented 4 years ago

Unfortunately I cannot fix time out, error 503 and expired certificate. As an option, I can restart this build later

mpratt commented 4 years ago

Hi @vkhramtsov ! Thanks for the PR, Ill be merging it later tonight. Dont worry about the failing tests I' ll take care of that, since your changes have nothing to do with them.

vkhramtsov commented 4 years ago

Hi. But I failed some tests with new code. Looks like everything works as before ;)

mpratt commented 4 years ago

Thanks for the PR, it has been merged. Tests are passing! Changes are available on master now, I will be tagging another version as soon as I make more modifications to providers/endpoints or on bugfixes.