Improve code - Githubissues

mpratt / Embera

A Oembed consumer library, that gives you information about urls. It helps you replace urls to youtube or vimeo for example, with their html embed code. It has advanced features like offline support, responsive embeds and caching support.

MIT License

335 stars 59 forks source link

Improve code #65

Closed vkhramtsov closed 4 years ago

vkhramtsov commented 4 years ago

[x] Tests improvements (use proper methods from php unit instead of php constructions and checks for true and false)
[x] Performance improved with using static for closures
[x] Optimize regular expressions (replace \w\d with just \w (because \w already include \d), remove excessive escaping, use character classes ([vl]) instead of or (v|l), remove i flag for patterns without alphabetical symbols)
[x] Remove obsolete imports
[x] Remove obsolete test
[x] Fix phpdoc in tests

vkhramtsov commented 4 years ago

I see some incomplete tests and some 50x errors. Should I investigate them? Locally I have only one incomplete test

mpratt commented 4 years ago

Thanks @vkhramtsov for the PR! I'll be taking a look at it tonight! Dont worry about the failing tests, I'll take care of it, travis sometimes has issues running the code, specially making requests to some providers, so dont worry. Sometimes the tests run fine locally, but travis complains about something.

vkhramtsov commented 4 years ago

@mpratt looking forward for your feedback

mpratt commented 4 years ago

Thanks @vkhramtsov Nice work, great catches! Merged and soon I'll be tagging 2.0.2

vkhramtsov commented 4 years ago

Perfect. I'm waiting for it because I want to upgrade your package to version 2 in our project

mpratt commented 4 years ago

Yeah, don't worry. I just added support for another provider (Avocode), Im just waiting for travis to run the tests and see if I need to update something else before tagging.