search

mpratt / Embera

A Oembed consumer library, that gives you information about urls. It helps you replace urls to youtube or vimeo for example, with their html embed code. It has advanced features like offline support, responsive embeds and caching support.
MIT License
335 stars 59 forks source link

Use correct Facebook endpoint for videos #77

Closed rawcomposition closed 3 years ago

rawcomposition commented 3 years ago

When using an access_token, the endpoint for Facebook videos is generated incorrectly because the type variable was set to videos (plural) instead of video. Note that the Facebook documentation also has a typo. At the top of the page under Endpoints they correctly indicate the endpoint as /oembed_video but towards the end of the page under Getting Embed HTML they incorrectly specify /oembed_videos. Only /oembed_video works, based on my testing.

rawcomposition commented 3 years ago

Oops, I just noticed this is a duplicate pull request. Feel free to close it (I'll leave it open for now since my description clarifies that the Facebook documentation also has a typo)

mpratt commented 3 years ago

Thanks @rawcomposition Yes indeed your pull request is duplicate but i'll be taking information from your commit message. I'll be releasing a new version over the weekend, thanks for the PR