search

mpratt / Embera

A Oembed consumer library, that gives you information about urls. It helps you replace urls to youtube or vimeo for example, with their html embed code. It has advanced features like offline support, responsive embeds and caching support.
MIT License
339 stars 59 forks source link

Soundcloud not working #8

Closed silentworks closed 10 years ago

silentworks commented 10 years ago

I am not sure if you tested this, but Soundcloud oEmbed is not working, I am unable to find the issue but If I do before you I will send in a PR.

mpratt commented 10 years ago

Hi!

Can you provide a sample url that is giving you troubles? I runned the Tests located at Tests/TestServiceSoundCloud.php and found out that one of the urls I had was failing because it was deleted/404'd. Other than that it seems to be working just fine.

However, I took another look at the Soundcloud site and found out that they had a mobile version too. So I added support for urls comming from that version of the site (http://m.soundcloud.com/...).

Please let me know if this last commit fixes your issue or if we need to dig a little deeper to find where the bug is :D!

Thanks for the report!