search

mpresill / LatinoAnalysis

Common tools for analysis
0 stars 0 forks source link

fix a bug in reading correct jet pt #6

Closed mpresill closed 2 years ago

mpresill commented 2 years ago

there is bug in reading fj pt. https://github.com/latinos/LatinoAnalysis/blob/master/NanoGardener/python/modules/FatJetMaker.py#L126 we would have to change: fj.pt ==> fj.pt_nom Comment: ft.pt method did not read the jet pt as recalculated from jetnanoaodtools (with updated JEC, ...).

SiewYan commented 2 years ago

You are referring to master branch of LatinoAnalysis..

I think this is not a bug: https://github.com/latinos/LatinoAnalysis/blob/UL_production/NanoGardener/python/modules/FatJetMaker.py#L126

fj.pt access the original pt if no suffix (_up,_down) are found.

It is alright for now because we are not processing Up and DOWN branches (we suppressed it [*]) , which is what Tomas's code is doing.

[*] https://github.com/mpresill/LatinoAnalysis/blob/UL_production/NanoGardener/python/modules/FatJetMaker.py#L58-L62

SiewYan commented 2 years ago

closing this issue, as it is clarified that the variation is performed in third step of the UL production.