search

mpromonet / v4l2rtspserver

RTSP Server for V4L2 device capture supporting HEVC/H264/JPEG/VP8/VP9
The Unlicense
1.82k stars 423 forks source link

Search for live555 library in the system #238

Closed jgomezlopez closed 3 years ago

jgomezlopez commented 3 years ago

CMakeList.txt search for previous system installation of liveMedia library

Add an alternative HTTPServer definition to be compliant with older liveMedia versions

mpromonet commented 3 years ago

Hi,

Thanks for the PR. I would merge without problem the HTTPServer fixes, maybe you can submit a separate PR for this. For the other stuff I still thinking (need some cleanup of dead line, moreover the hardcoding of live dependencies version is not maintable across different OS version). Why did you like to share the live555 libraries ? to reduce space on your target ?

Best Regards, Michel.

jgomezlopez commented 3 years ago

Hi Michel,

I have several reasons for sharing the live555 library. 1 - Of course, to reduce space on my target 2 - To link with stable and long term versions, approved by the Linux distributions maintainers 3 - In the future, if you agree, have v4l2rtspserver in the Linus distributions 4 - When I download the latest version of live555 I get an error uncompressing it, the file seems to be corrupted 5 - If you don't have the library installed, I preserved the strategy of downloading the latest version of live555

On the other hand I don't see any hardcode dependencies. I only created a bunch of "Find" files help us to find the libraries by providing CMake packages for those libraries, they don't check any versions. It is quite similar you do with the log library and alsa library, but those projects have the dependencies defined in a CMake Package.

Regards,

José

mpromonet commented 3 years ago

Hi,

My concern was :

    SET(CPACK_DEBIAN_PACKAGE_DEPENDS ${CPACK_DEBIAN_PACKAGE_DEPENDS}liblivemedia50,)
    SET(CPACK_DEBIAN_PACKAGE_DEPENDS ${CPACK_DEBIAN_PACKAGE_DEPENDS}libusageenvironment3,)
    SET(CPACK_DEBIAN_PACKAGE_DEPENDS ${CPACK_DEBIAN_PACKAGE_DEPENDS}libbasicusageenvironment1,)
    SET(CPACK_DEBIAN_PACKAGE_DEPENDS ${CPACK_DEBIAN_PACKAGE_DEPENDS}libgroupsock8,)

The number changes depending on release, this is annoying. But ok as there is no breaking change if live is not installed, I will merge your request.

Thanks.

Michel.

jgomezlopez commented 3 years ago

Hi Michel,

Those dependencies are only for Debian and Ubuntu Packaging, not for libraries searching.

Regards,

José

mpromonet commented 3 years ago

Hi José,

I replaced it with livemedia-utils that have them as dependencies, but have a stable name.

Best Regards, Michel.