search

mpromonet / v4l2rtspserver

RTSP Server for V4L2 device capture supporting HEVC/H264/JPEG/VP8/VP9
The Unlicense
1.82k stars 423 forks source link

Building against live555 2021-11-14 fails #259

Closed baryonicnonsense closed 2 years ago

baryonicnonsense commented 2 years ago

Building against live555 version 2021-11-14 fails with

[v4l2rtspserver]  In file included from /app/live/liveMedia/include/GenericMediaServer.hh:29,
[v4l2rtspserver]                   from /app/live/liveMedia/include/RTSPServer.hh:25,
[v4l2rtspserver]                   from /app/src/HTTPServer.cpp:19:
[v4l2rtspserver]  /app/live/liveMedia/include/ServerMediaSession.hh:125:16: note: candidate: ‘virtual void ServerMediaSubsession::getStreamParameters(unsigned int, const sockaddr_storage&, const Port&, const Port&, int, unsigned char, unsigned char, TLSState*, sockaddr_storage&, u_int8_t&, Boolean&, Port&, Port&, void*&)’
[v4l2rtspserver]     virtual void getStreamParameters(unsigned clientSessionId, // in
[v4l2rtspserver]                  ^~~~~~~~~~~~~~~~~~~
[v4l2rtspserver]  /app/live/liveMedia/include/ServerMediaSession.hh:125:16: note:   candidate expects 14 arguments, 13 provided

The code in question here

https://github.com/mpromonet/v4l2rtspserver/blob/90dfcb1ec09415ec59615976703a012fda3391f2/src/HTTPServer.cpp#L345

requires an additional parameter introduced by live555, tlsState referenced in include/ServerMediaSession.hh:125

  virtual void getStreamParameters(unsigned clientSessionId, // in
                                   struct sockaddr_storage const& clientAddress, // in
                                   Port const& clientRTPPort, // in
                                   Port const& clientRTCPPort, // in
                                   int tcpSocketNum, // in (-1 means use UDP, not TCP)
                                   unsigned char rtpChannelId, // in (used if TCP)
                                   unsigned char rtcpChannelId, // in (used if TCP)
                                   TLSState* tlsState, // in (used if TCP)
                                   struct sockaddr_storage& destinationAddress, // in out
                                   u_int8_t& destinationTTL, // in out
                                   Boolean& isMulticast, // out
                                   Port& serverRTPPort, // out
                                   Port& serverRTCPPort, // out
                                   void*& streamToken // out
mpromonet commented 2 years ago

Hi,

Thanks, it should be fixed with commmit 9638a1573b2cca57dbefc81ba8fbcd5627056ba1

Best Regards, Michel.