search

mpromonet / v4l2rtspserver

RTSP Server for V4L2 device capture supporting HEVC/H264/JPEG/VP8/VP9
The Unlicense
1.82k stars 423 forks source link

[BUGFIX #299] Do not exit thread upon EAGAIN error when fetching frames #301

Closed azsde closed 1 year ago

azsde commented 1 year ago

To use the latest Camera v3 from Raspberry Pi, we need to use libcamerify which is a V4L2 compatibility layer preload.

libcamerify -d v4l2rtspserver

I don't know if it is due to libcamerify, but sometimes the camera seems to be temporary unavailable:

[NOTICE] /home/azsde/v4l2rtspserver/src/V4L2DeviceSource.cpp:203 V4L2DeviceSource::getNextFrame errno:11 Resource temporarily unavailable [ERROR] /home/azsde/v4l2rtspserver/src/V4L2DeviceSource.cpp:111 error:Resource temporarily unavailable [NOTICE] /home/azsde/v4l2rtspserver/src/V4L2DeviceSource.cpp:122 This causes v4l2rtspserver to hang indefinitely.

Looking into the code, it seems that if V4L2DeviceSource cannot get the next frame, it will stop the thread in charge of fetching the the frames, not matter what error we have.

Instead of doing so, we check the errno for the EAGAIN value and do not exit if errno equals EAGAIN.

mpromonet commented 1 year ago

Hi,

I will probably prefer to manage this in V4L2DeviceSource::getNextFrame, I will merge this.

Thanks & Regards

Michel.