mpromonet / v4l2rtspserver

RTSP Server for V4L2 device capture supporting HEVC/H264/JPEG/VP8/VP9
The Unlicense
1.82k stars 423 forks source link

Methods are not used anywhere isKeyFrame and getInitFrames #325

Closed Zerpico closed 4 months ago

Zerpico commented 4 months ago

The V4L2DeviceSource class and its descendants (H264_V4L2DeviceSource, H264_V4L2DeviceSource) have methods that are not used anywhere.

bool isKeyFrame(const char* buffer, int size)
std::list< std::string > getInitFrames()

https://github.com/mpromonet/v4l2rtspserver/blob/master/inc/V4L2DeviceSource.h#L82

What are they needed for ?

mpromonet commented 4 months ago

Hi,

These methods are used by v4l2camera. https://github.com/mpromonet/v4l2camera/blob/master/src/v4l2web.cpp#L185

Best Regards Michel