search

mpromonet / webrtc-streamer

WebRTC streamer for V4L2 capture devices, RTSP sources and Screen Capture
https://webrtcstreamer.agreeabletree-365b9a90.canadacentral.azurecontainerapps.io/?layout=2x2
The Unlicense
2.8k stars 581 forks source link

rtc_json.lib missing and no known rule to make it #633

Closed davidjytang closed 8 months ago

davidjytang commented 8 months ago

Describe the bug rtc_json.lib is no longer built using latest webrtc at the time of reporting (2023-NOV-02). Missing rtc_json.lib results in ninja not able to run. Error message: ninja: error: 'C:/webrtc/src/out/Release/obj/rtc_base/rtc_json.lib', needed by 'webrtc-streamer', missing and no known rule to make it

To Reproduce Please compile webrtc-streamer with latest webrtc as of now (2023-NOV-02)

Desktop (please complete the following information):

Additional context I have found this diff at webrtc, which might be the culprit on why rtc_json.lib is no longer built for the use of webrtc-streamer's CMakeList.txt

I have tried commenting out the test_only field like the following:

rtc_library("rtc_json") {
#  testonly = true

The compilation went through successfully.

I of course defer to @mpromonet 's judgement on how to go about this.

davidjytang commented 8 months ago

I'm sorry.

It seems that @mpromonet has already responded to the latest webrtc change with this commit https://github.com/mpromonet/webrtc-streamer/commit/c2448a33f2bb30ee8a5b83c77f2e923f041a0c9c

I will close this issue after I get a chance to compile.

davidjytang commented 8 months ago

Confirmed rtc_json.lib compile issue is no longer relevant. Closing now.