When parse h264 sps, its width and height was never right

mpromonet / webrtc-streamer

WebRTC streamer for V4L2 capture devices, RTSP sources and Screen Capture

https://webrtcstreamer.agreeabletree-365b9a90.canadacentral.azurecontainerapps.io/?layout=2x2

The Unlicense

2.8k stars 581 forks source link

When parse h264 sps, its width and height was never right #696

Closed howardhuang666 closed 1 month ago

howardhuang666 commented 1 month ago

1715853688472 1715854081498 1715854179224 sorry for my english. In your code, absl::optional sps = webrtc::SpsParser::ParseSps(buffer + index.payload_start_offset, index.payload_size); buffer + index.payload_start_offset includes nalu type, but webrtc::SpsParser::ParseSps will read first byte as profile_idc, so sps.width and sps.height was never right, may you can fix it, that was confused.