search

mpruvot / python_chess_app

0 stars 0 forks source link

Name: `service` is a bad name. #10

Closed pbrochar closed 9 months ago

pbrochar commented 9 months ago

https://github.com/mpruvot/python_chess_app/blob/9a22b93faca5e7b7fc8a8d75bca898c75c7f34fe/api/chess_engine_api.py#L14C1-L14C29

We don't name things about their role in the code, like function is a bad function name, model is a bad Pydantic name for a model 😄

mpruvot commented 9 months ago

fixed