Closed tommysolsen closed 1 year ago
@tommysolsen Clearly I haven't been responding to things here much. So I've just made you an admin for the mps-youtube repo.
LGTM. @tommysolsen Anything else needed here?
pip install
invocations would be desirable to use --no-cache
requirements.txt
develop
is now behind master
)/cc @iamtalhaasghar
i dont use docker much. If u can take care of maintenance of docker stuff then u are free to take necessary decisions as no other contributor / owner is actively working on this project. This PR has a conflict and won't merge. As per my knowledge we you will have to create a new PR with all docker related configs / github actions and we can discuss and merge it to master branch. Is there any other way of resolving conflict?
Edit: i've updated develop branch.
feel free to open new PR. Closing this one. @pataquets
Before merging this PR we need to set up some tokens for Github Actions to be able to push to dockerhub
Dockerfile changes
We now build the Docker image from the source code in the repository instead of downloading the newest version of pip. This way we can release multiple images of different (and unreleased versions) through dockerhub.
New mpsyt organization on dockerhub.
I've created a new organization for mpsyt on dockerhub. I'll have to somehow get in touch with contributors in the mpsyt org in order to add them to the org and sort out owner rights at some point.
Github actions
This PR also adds a few simple workflows that lets us automatically build images when we update the master and develop branch of the repository. The images are pushed to the aforementioned newly created org.
In order to facilitate that, we need to set a dockerhub secret to grant push rights. However it looks like only @ids1024 has access to do that. I can add him as owner to the dockerhub org, then he can create a security token and add that to the repo secrets and then we can automatically perform changes here.
We could/should also set up some schedule based workflows which would check and rebuild the images if youtube-dl has been updated. As well as building tagged versions of the software as well.