search

mps-youtube / yewtube

yewtube, forked from mps-youtube , is a Terminal based YouTube player and downloader. No Youtube API key required.
GNU General Public License v3.0
8.07k stars 645 forks source link

Remove special letters from filename #1077

Closed rayluo closed 4 years ago

rayluo commented 4 years ago

Otherwise, titles with such letters won't be able to downloaded

jas32096 commented 4 years ago

Seems like this should already be handled by sanitize_filename. https://github.com/mps-youtube/mps-youtube/blob/afab9fbc9ba61c646e406c6754e589c9c0c15c77/mps_youtube/util.py#L129-L140

What OS are you using that doesn't allow # in filenames?

rayluo commented 4 years ago

You have a point. My sanitizing # was probably unnecessary. I was in a hurry to throw out some quick hack to get my download working.

And thanks to your hint to the sanitize_filename(). It turned out it was introduced just 7 months ago, but the mps-youtube shipped in my Linux-distro is still 0.2.8, released at 2 years ago. No wonder.

You can close this PR, then.

BTW, are you a maintainer of this project? Do you know whether this project will have a new release anytime soon? Too bad, I wasted my mid-night oil trying to debug this program.

jas32096 commented 4 years ago

Not a maintainer. Just a contributor. They don't seem to do releases often. My advice would be to avoid using your package manager and just point pip at this repo. pip3 install --upgrade git+https://github.com/mps-youtube/mps-youtube.git