search

mps-youtube / yewtube

yewtube, forked from mps-youtube , is a Terminal based YouTube player and downloader. No Youtube API key required.
GNU General Public License v3.0
8.09k stars 644 forks source link

random crash i keep getting #1138

Closed autoteelar closed 1 year ago

autoteelar commented 3 years ago

on the latest pip3 install the development version Traceback (most recent call last): File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner self.run() File "/usr/lib/python3.9/threading.py", line 892, in run self._target(*self._args, *self._kwargs) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/mpris.py", line 227, in bindmpv self.setproperty(resp['name'], resp['data']) KeyError: 'data' Traceback (most recent call last): File "/bin/mpsyt", line 33, in sys.exit(load_entry_point('mps-youtube==0.2.8', 'console_scripts', 'mpsyt')()) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/main.py", line 153, in main if matchfunction(i.function, i.regex, userinput): File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/main.py", line 70, in matchfunction func(matches) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/commands/play.py", line 102, in play g.PLAYER_OBJ.play(songlist, shuffle, repeat, override) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/player.py", line 79, in play self._playsong() File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/player.py", line 138, in _playsong self._launch_player() File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/player.py", line 298, in _launch_player self.launch_player(cmd) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/players/mpv.py", line 135, in launch_player self._player_status(self.songdata + "; ", self.song.length) File "/home/ralts/.local/lib/python3.9/site-packages/mps_youtube/players/mpv.py", line 188, in _player_status if resp['data'] is not None: KeyError: 'data'

autoteelar commented 3 years ago

i think its caused by pressing Q in mpv

autoteelar commented 3 years ago

it also happens randomly for some videos before it starts playing, like when i press 6 to play the 6th one in the list

Masacaai commented 3 years ago

This is a duplicate of this issue. Apply the changes mentioned in that commit and it should start working as intended.

autoteelar commented 3 years ago

thank you :D

autoteelar commented 3 years ago

i will try