mps-youtube / yewtube

yewtube, forked from mps-youtube , is a Terminal based YouTube player and downloader. No Youtube API key required.
GNU General Public License v3.0
8k stars 643 forks source link

use dict.get("foo") instead of dict["foo"] #1172

Closed tcaxle closed 1 year ago

tcaxle commented 2 years ago

In order to prevent following catastrophic error that I often encounter.

Traceback (most recent call last):                                                                                                                                                                             
  File "/usr/bin/mpsyt", line 33, in <module>
    sys.exit(load_entry_point('mps-youtube==0.2.8', 'console_scripts', 'mpsyt')())
  File "/usr/lib/python3.9/site-packages/mps_youtube/main.py", line 153, in main
    if matchfunction(i.function, i.regex, userinput):
  File "/usr/lib/python3.9/site-packages/mps_youtube/main.py", line 70, in matchfunction
    func(*matches)
  File "/usr/lib/python3.9/site-packages/mps_youtube/commands/play.py", line 121, in play_all
    play(options, "1-" + str(len(g.model)))
  File "/usr/lib/python3.9/site-packages/mps_youtube/commands/play.py", line 102, in play
    g.PLAYER_OBJ.play(songlist, shuffle, repeat, override)
  File "/usr/lib/python3.9/site-packages/mps_youtube/player.py", line 79, in play
    self._playsong()
  File "/usr/lib/python3.9/site-packages/mps_youtube/player.py", line 138, in _playsong
    self._launch_player()
  File "/usr/lib/python3.9/site-packages/mps_youtube/player.py", line 298, in _launch_player
    self.launch_player(cmd)
  File "/usr/lib/python3.9/site-packages/mps_youtube/players/mpv.py", line 135, in launch_player
    self._player_status(self.songdata + "; ", self.song.length)
  File "/usr/lib/python3.9/site-packages/mps_youtube/players/mpv.py", line 188, in _player_status
    if resp['data'] is not None:
KeyError: 'data'
otisdog8 commented 2 years ago

Could you merge it into here? https://github.com/otisdog8/termitube/ I'm making a fork because the repository is mostly unmaintained

iamtalhaasghar commented 1 year ago

was fixed here https://github.com/iamtalhaasghar/yewtube/commit/7966a7a9178ecd3a87ae6dcb10f5fce45551d776