mpsq / emacs-gcc-wayland-devel-builder

Emacs with native compilation ("gcc") and Wayland support
https://aur.archlinux.org/packages/emacs-gcc-wayland-devel-bin/
91 stars 5 forks source link

Release 28.2.50 changelog reflect incorrect upstream branch #30

Closed mangkoran closed 1 year ago

mangkoran commented 1 year ago

First of all, thank you for your hard work maintaining this package. It is truly time-saving for us who want to quickly use pgtk and JIT Emacs.

It seems that the upstream this repo use to build Emacs is yet to update to 28.2. The latest commit on flatwhatson's was on May 17. If we see the the Emacs upstream at Savannah, 28.2 is released on 2022-09-12.

Screenshot_20221012-063045_Chrome

Apologize for not testing the package first, but is the new release actually updated to 28.2?

mangkoran commented 1 year ago

Except, if what you actually use is their dev branch, which is actively updated by them. Could you confirm this?

Edit: Apologize for not checking your commit before. It seems you have indeed changed the upstream branch to pgtk-nativecomp-dev here. It is just the release changelog that made me confused, as it only reflects changes on the main branch. Could the release changelog be updated to better reflect the changes?

mangkoran commented 1 year ago

Additionally, the AUR's pkgver is yet to be updated too.

image

mpsq commented 1 year ago

This is coming, I changed various bits for 28.2 yesterday. I want to test the package first (which I will do today), if everything works as expected I will release it on AUR and re-enable the automation ;)

mpsq commented 1 year ago

The changelog is auto-generated using GitHub's api. The reason why it is truncated is because it is too big (so it is actually paged). I don't have time to like into this tbh, I want to prioritize the release first. PRs are welcome though, the relevant script can be tweaked to handle paging properly https://github.com/mpsq/emacs-gcc-wayland-devel-builder/blob/main/scripts/build-artifacts.bash#L35

mangkoran commented 1 year ago

I will check the code first and try to help whenever I can.

Then, I will close this issue. Thank you for your response!