mpsquare / upnext

0 stars 0 forks source link

Code Rubric #10

Open matthewpeixoto opened 6 years ago

matthewpeixoto commented 6 years ago
0 points 1 points 2 points 3 points
Accessibility No considerations Added some alt attributes, nothing else Just the basics: alt attributes, roles Accessibility is well considered and tested
Code quality Barely started Indentation is barely existent, lots of validation errors, very poor semantics Decent indentation, just a couple validation errors, decent semantics Well indented, fully valid, good semantics
Responsiveness Broken on one or more screen sizes Contains awkward spacing and responsiveness issues when resizing viewport Looks and works well on all screen sizes but doesn't effectively adapt based on viewport Look and functionality is greatly considered on mobile devices, takes full advantage of space on desktop
Performance Incredibly slow, no steps taken to reduce load times Pretty slow Decent, some steps taken to reduce load times Really fast, lots of steps taken to reduce load times
franchescamansour commented 6 years ago

Accessibility (2.5 Points)

We believe that our accessibility is great. We have good colours chosen, styled focus states, alt attributes, keyboard accessible and we have aria labels. However, the only issue is that we can break through the modal if the user keeps tabbing.

Code Quality ( 3 Points)

We believe that our code has been well written. Proper semantics applied, organized files and folders, and consistent styles on all our gutters, colours etc. We also made sure to always commit to GitHub.

Responsiveness ( 3 Points)

Our website is very responsive, we made sure to check every page for all screen sizes and ensured that all text and images are consistently aligned. The website will look good on difference devices.

Performance ( 2.5 Points)

Considering that we have a website full images, we took all the measures to try and reduce the file sizes as much as we can. We chose the smallest retina friendly size for all images and dropped them all into ImageOptim to compress the size.

@thomasjbradley