search

mpstark / DynamicCam

A more dynamic camera for World of Warcraft.
MIT License
22 stars 11 forks source link

Set zoom not working in Cataclysm Classic #96

Open classicalpunk opened 1 month ago

classicalpunk commented 1 month ago

Hi,

First, thank you for this addon, I use it on retail and classic for quite some time now and I love it.

The issue I have arose with Cataclysm Classic where the Set Zoom option is not working anymore in set situations. I usualy use it when I'm in mounted situation or in combat to have a more distant view and it was working correctly in WOTLK Classic.

As you can see the situation is well recognised, but the zoom level does not change when I enter or exit it. (if I use the /zi function for this screenshot it shows 13.88) image

If I use the set view option instead it works correctly but customized views are not what I need here unfortunately. Actually, all other options seems to be working fine.

Edit 1 : Also, if I do a /reload while mounted, it then zooms out correctly to the set distance, but it doesn't change anymore afterward. Edit 2 : If I zoom out while on foot then mount, it goes to the set view of the parent situation (in this case I set the "world" view to standard view 5, so it goes back to that standard view if I mount). Edit 3 : Removing any parent situation allow the "set zoom" option to act correctly (I actually have the "world" situation activated with "set view" on) -> Maybe a priority issue between the two situations ?

Thank you again !

LudiusMaximus commented 1 month ago

Hello and thanks for your kind words. :-) Also thanks for your elaborate description of the issue. I just tried to reproduce what you are experiencing. But I find the "Set Zoom" to work as expected when I change situations.

Have you tried using "Zoom Type" "Set" instead of "Out"? Does it still not work for you then? Have you also tried running DynamicCam as your only enabled addon to make sure there is not other addon interfering?

If you have checked all of that, maybe you want to send me your WTF\Account\\SavedVariables\DynamicCam.lua file. So I can replicated your exact settings. Just post the content here or send it to ludiusmaximus@gmail.com.

Looking forward to hearing from you again.

classicalpunk commented 1 month ago

Hello,

I did try different settings for the Zoom Type and also only activating the DynamicCam addon but it didn't change a thing.

You'll find the lua file attached, hopefully you'll find something to work it out.

DynamicCam.zip

LudiusMaximus commented 1 month ago

Hello, and thanks for your configuration file. I could now see what your issue is. And it is like you suggested in your Edit 3.

In the logic of DynamicCam a "set view" always overrides a "set zoom". And "set view" also includes "restore view". In your parent situations you have "set view" with "restore" enabled. So whenever, you leave these situations the saved view of when you entered them is restored, which overrides a possible "set zoom" of the other situation you are entering.

It could be programmed differently, such that the "set zoom" of an entered situation overrides (or maybe even better follows) the "restore zoom" of the previous situation. I will consider it.

For the time being, it would probably make most sense for you to disable "restore view" for your parent situations.

That you just noticed this problem with the launch of Cata classic must have been a coincidence, because it has always been like this.

Thanks again for getting in touch! Let me know if you need anything else.