mpstark / FixMaxPrioritySalvage

Fixes a bug where if max salvage was above 7, you could not continue. Now, priority max salvage is capped at 7. Also fixes UI ignoring `PrioritySalvageModifier`.
0 stars 0 forks source link

Skirmish Mode will not function with this .dll present #1

Closed TimeDiver0 closed 6 years ago

TimeDiver0 commented 6 years ago

More specifically, after choosing the desired lance/map combination and clicking on 'Play', the game soft freezes at a blank/empty screen.

Game never transitions to the objective list ('Destroy Enemy Lance') and background image of a Leopard dropship + 'Preparing for Combat' button.

Relevant excerpt from output_log.txt:

NullReferenceException: Object reference not set to an instance of an object
at FixMaxPrioritySalvage.Briefing_SetContractInfo_Patch.Postfix (BattleTech.UI.Briefing,BattleTech.Contract,BattleTech.SimGameState) <0x000fc>
at (wrapper dynamic-method) BattleTech.UI.Briefing.SetContractInfo_Patch1 (object,BattleTech.Contract,BattleTech.SimGameState) <0x0074f>
at BattleTech.UI.Briefing.Init () <0x00ae1>
at BattleTech.UI.UIManager.AddModule (BattleTech.UI.UIModule,BattleTech.UI.UIManager/UINode,int,bool) <0x00219>
at BattleTech.UI.UIManager.GetOrCreateAtNode (System.Type,string,BattleTech.UI.UIManager/UINode,bool,bool) <0x0022d>
at BattleTech.UI.UIManager.CreatePopupModule (System.Type,string,bool) <0x00056>
at BattleTech.UI.ModuleAutoLauncher.Launch () <0x00118>
at BattleTech.UI.ModuleAutoLauncher/<Start>c__Iterator0.MoveNext () <0x000a3>
at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator,intptr) <0x00058>

Am using the ModTek.dll file you kindly provided for me (enabling the optional '"AddToDB": false' flag for mod.json).

Renaming/deleting FixMaxPrioritySalvage.dll resolved the issue with Skirmish, so I'm ~95% certain that this mod is the sole culprit.

mpstark commented 6 years ago

I've fixed this and will upload a new release soon. Thanks for catching it, I don't often use the skirmish mode.