Open singmann opened 6 years ago
In TreeBUGS, the C++ samplers (simpleMPT
, betaMPTcpp
) use custom Gibbs samplers with conjugate posteriors and thus allow for non-integer data.
However, traitMPT
and betaMPT
require calling JAGS, which complains when one supplies non-integer data: Failed check for discrete-valued parameters in distribution dmulti
Since this warning and error output occurs at a very low-level part of the code, I would prefer to stick with the present check.
Hmm, I mean we could still make this check then conditional on using either of those methods, but I think this might not be super urgent. Nevertheless, we can keep the issue open.
Currently
fit_mpt
contains the following check (lines 74-82):I know that data should usually be integers, but at least
MPTinR
can work with non-integer values as well. For example, such values can occur if one wants to fit predicted probabilities or when using some correction for zero-cells. As long asTreeBUGS
(@danheck ) not has a problem with non-integer data I suggest to downgrade thestop
to awarning
.