search

mpt-network / MPTmultiverse

An R package for the comparison of MPT analysis approaches
3 stars 6 forks source link

Update required for R 3.6 #23

Closed singmann closed 5 years ago

singmann commented 5 years ago

I have received the following email today from CRAN:

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_MPTmultiverse.html.

The check problems with current R-devel are from

 • The default method for generating from a discrete uniform
   distribution (used in sample(), for instance) has been changed.
   ...
   The previous method can be requested using RNGkind() or
   RNGversion() if necessary for reproduction of old results.

To make your package successfully pass the checks for current R-devel and R-release you may find it most convenient to insert

suppressWarnings(RNGversion("3.5.0"))

before calling set.seed() in your example, vignette and test code (where the difference in RNG sample kinds matters, of course).

Note that this ensures using the (old) non-uniform "Rounding" sampler for all 3.x versions of R, and does not add an R version dependency. Note also that the new "Rejection" sampler which R will use from 3.6.0 onwards by default is definitely preferable over the old one, so that the above should really only be used as a temporary measure for reproduction of the previous behavior (and the run time tests relying on it).

Please correct before 2019-03-20 to safely retain your package on CRAN.

Best, -k

In summary: The default RNG in R will change in the next R version. This affects some of our checks (as they compare against precalculated results). This is most likely also the reason for the failues we see on TRAVIS-CI since yesterday. I will try to provide a fix today.

singmann commented 5 years ago

I think I have fixed this issue, but there seems to be some unrelated issue with R-devel at the moment that leads to a failing check. I expect this problem to disappear automatically in a few days.

Given the deadline, I plan to push the next version of the package to CRAN at the beginning of next week. Any additional changes should be done by then or a message posted here if release should be pushed to a later date.

singmann commented 5 years ago

The current version is on its way to CRAN.

singmann commented 5 years ago

CRAN autochecks reported the following:

Dear maintainer,

package MPTmultiverse_0.2-0.tar.gz has been auto-processed. The auto-check found additional issues for the last version released on CRAN: noLD https://www.stats.ox.ac.uk/pub/bdr/noLD/MPTmultiverse.out CRAN incoming checks do not test for these additional issues, hence please reply-all and explain: Have these been fixed?

It appears, the "noLD" checks are checks without support for long-double data types (see: https://www.rdocumentation.org/packages/tools/versions/3.5.2/topics/CRANtools). However, checking the link reveals that the issues are the same as the one reported on the main check page and the reason why we resubmitted the current version. They also make sure it is not for the new, but the last submitted version. I will make this point to CRAN.

singmann commented 5 years ago

It is on its way to CRAN now. Closing.