search

mpt-network / MPTmultiverse

An R package for the comparison of MPT analysis approaches
3 stars 6 forks source link

Use C++ implementation of beta-MPT #7

Closed mariusbarth closed 6 years ago

mariusbarth commented 6 years ago

I don't know if I remember correctly: Should we use the C++ version of beta-MPT as a default?

danheck commented 6 years ago

In the first tests of the script, the betaMPTcpp (C++) function did not crash for a few models whereas betaMPT (JAGS) crashed. Moreover, the results are identical if both methods work.

Therefore, I think it is reasonable to use betaMPTcpp as a default. Does anybody have other opinions or experiences, in which case betaMPT worked but betaMPTcpp did not?

mariusbarth commented 6 years ago

I didn't check betaMPTcpp, but the JAGS variant crashed sometimes. Probably the most sensible solution would be to additionally implement the C++ version, keep the JAGS version as it is, and set only the C++ version as the default method.

danheck commented 6 years ago

betaMPTcpp now supported via method="betacpp": https://github.com/mpt-network/MPTmultiverse/commit/af7e6cb0b35809ef2ea74297216b5963513d0059