search

mptre / pick

A fuzzy search tool for the command-line
MIT License
814 stars 42 forks source link

Build Broken GCC 10.0.1 (Fedora 32) #301

Closed FreedomBen closed 4 years ago

FreedomBen commented 4 years ago

The build is failing on Fedora 32, GCC 10.0.1:

[ben@localhost pick]$ make
cc -Wall -Wextra -MD -MP    -c -o compat-pledge.o compat-pledge.c
cc -Wall -Wextra -MD -MP    -c -o compat-reallocarray.o compat-reallocarray.c
cc -Wall -Wextra -MD -MP    -c -o compat-strtonum.o compat-strtonum.c
cc -Wall -Wextra -MD -MP    -c -o pick.o pick.c
cc  -o pick compat-pledge.o compat-reallocarray.o compat-strtonum.o pick.o -lcurses
/usr/bin/ld: compat-reallocarray.o:(.bss+0x0): multiple definition of `unused'; compat-pledge.o:(.bss+0x0): first defined here
/usr/bin/ld: compat-strtonum.o:(.bss+0x0): multiple definition of `unused'; compat-pledge.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make: *** [/home/ben/gitclone/pick/Makefile:70: pick] Error 1

GCC information:


[ben@localhost pick]$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,objc,obj-c++,ada,go,d,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.0.1 20200328 (Red Hat 10.0.1-0.11) (GCC)```

Please let me know if additional information would be helpful.
FreedomBen commented 4 years ago

I submitted #302 to fix this.

Happy to rename the variables instead if they are needed.

mptre commented 4 years ago

Thanks, lets continue the discussion in #302.