search

mptwaktusolat / app_waktu_solat_malaysia

Prayer times app for Malaysia. Accurate data from JAKIM. Install the app on your phones now.
https://play.google.com/store/apps/details?id=live.iqfareez.waktusolatmalaysia
GNU General Public License v3.0
44 stars 21 forks source link

[Feedback] Notification Waktu Solat Tidak Berfungsi/Berbunyi #103

Closed fire-bot closed 2 years ago

fire-bot commented 2 years ago

Sent by Malaysia Prayer Time MPT (mptwaktusolat@gmail.com). Created by fire.

---------- Forwarded message ---------
Date: Wed, Mar 2, 2022 at 7:40 PM
Subject: Notification Waktu Solat Tidak Berfungsi/Berbunyi
To: [mptwaktusolat@gmail.com](mailto:mptwaktusolat@gmail.com)

Assalamualaikum wbth,

Saya salah seorang pengguna Malaysia Prayer Time 2022.

Selepas saya mengemaskini (update) aplikasi tersebut beberapa hari yang lepas,

saya dapati notification ketika masuk waktu solat tidak berfungsi/berbunyi seperti sebelum ini.

Harap pihak tuan dapat memeriksa ataupun menaiktaraf aplikasi tersebut.

Sekian, terima kasih.

____

____

iqfareez commented 2 years ago

Thank you for all user that reported to me about the issue :fire:

Sorry for late action, a lil busy.

iqfareez commented 2 years ago

Alhamdulillah this issue is fixed in the latest release.

It is caused by the JAKIM api responses now uses english month.

Example before was 04-Mei-2022, now it is 04-May-2022.

Fortunately, there is no crashes etc, that's why it quite late for me to detect the error. The parser failed to parse and return the month 0, ie it will become 04-0-2022, and the rest of the code treat it as 04-12-2021 (a month before).

Refer diff https://github.com/mptwaktusolat/app_waktu_solat_malaysia/commit/a8331898a04a0e83cb2c6be5f50d51501d067ec1#diff-7af4d36a1b33e75931f0e957316707ce0a9dafcaf861f547a4a966ba73b24458