search

mptwaktusolat / app_waktu_solat_malaysia

Prayer times app for Malaysia. Accurate data from JAKIM. Install the app on your phones now.
https://play.google.com/store/apps/details?id=live.iqfareez.waktusolatmalaysia
GNU General Public License v3.0
45 stars 22 forks source link

Wrong Serdang location #28

Closed iqfareez closed 3 years ago

iqfareez commented 3 years ago

This bug may affect people around Serdang, Selangor.

The issue caused from https://mpt.i906.my/ API.

We might issue a temporary fix for this. image

Any PR is welcomed.

iqfareez commented 3 years ago

Proposed Solution:

by Aizal Manan from email

  1. Go to https://api.azanpro.com/zones and copy their listing into your DB
  2. Get device location
  3. Using radius, get nearest zone from listing in Step 1
  4. Pass that zone code to https://www.e-solat.gov.my/index.php?r=esolatApi/takwimsolat&period=week&zone=SGR01

That's mean, we need to kinda rebuild the backend. We are also slowly ditching current 3rd party API (mpti906),

iqfareez commented 3 years ago

Screenshot 2021-01-30 081420

Alhamdulillah, I was be able to perform above pseudocode, it works well. So far, it matches with jakim code database in every location is tested.

iqfareez commented 3 years ago

Check passed. Will implement it soon

iqfareez commented 3 years ago

Beta release out now :eyes:

iqfareez commented 3 years ago

Fixed in latest release. Closing.