search

mptwaktusolat / app_waktu_solat_malaysia

Prayer times app for Malaysia. Accurate data from JAKIM. Install the app on your phones now.
https://play.google.com/store/apps/details?id=live.iqfareez.waktusolatmalaysia
GNU General Public License v3.0
45 stars 21 forks source link

Offsetted hijri date #54

Closed iqfareez closed 2 years ago

iqfareez commented 3 years ago

As per Subia's email:

Assalamu'alaikum. Hari Bulan utk Bln Islam thn Hijrah ini awl sehari.,

I've checked with Google, JAKIM, home calendar and there is indeed some variation in hijri time (refer images). Perhaps we can add date offset feature to the app. Before Ramadhan Inshallah.

image image

Debug

  ----------------------APP--------------------------
                        Version: 1.12.76-stable, VersionCode: 36
                        ---------------------DEVICE---------------------
                        Android 10 (SDK 29), Xiaomi Redmi Note 9 Pro
                        Hardware: qcom
                        Screen size (392.7, 825.5) DiP
                        PixRatio 2.75
iqfareez commented 3 years ago

Received report from other users from email. Awallaa mapleee hahhahahha uhuhu bnyak kerje do sorry

iqfareez commented 3 years ago

Using: https://github.com/ahmedoid/hijri_date/issues/6#issuecomment-778739269

iqfareez commented 3 years ago

alhamdulillah https://user-images.githubusercontent.com/60868965/112744602-17332a80-8fd4-11eb-8a6e-b82cffb74ec0.mp4

iqfareez commented 3 years ago

Reopen. Some folks noticed that the date is wrong where it supposed to show 1 Ramadan, but instead it shows 30 Shaaban.

Please refresh the date. It's already 1st of Ramadhan NOT 30th of Sya'aban

change to ramadhan 13/4/21. 1 ramadhan 1442

Thank you both of you submitting the report. It really helps. I'm working on temporary solution asap. A long term solution is already in mind, but I think it will take quite some time to implement.

iqfareez commented 3 years ago

Someone reported:

Salam. Kalendar islam tidak update. Lewat sehari.

So, I've no idea how to implement Remote Config in the app ahhaah

iqfareez commented 2 years ago

Done. Pretty easy implementation actually. Test pre-release app now: https://github.com/iqfareez/app_waktu_solat_malaysia/releases/tag/1.24.132-pre%2B62

iqfareez commented 2 years ago

Quickly made a web app to know how many days I need to offset

https://mpt-hijri-converter.web.app/#/

iqfareez commented 2 years ago

Reopening this issue.

On 2 Feb 2022, it supposed to be 30 J.Akhir (based on Jakim), but the app shows 1 Rejab.

Attempt to offset the hijri date also failed as there is no 30 J.Akhir available.

https://user-images.githubusercontent.com/60868965/152076788-47c47606-5f1e-49b7-be93-3499522168cd.mp4

Thinking of other viable and long term solution, maybe just use the prayer data.

iqfareez commented 2 years ago

alhamdulillah

Fixed in latest release, We now use the hijri date available together during prayer times api calls.