mpullis / elysium

0 stars 0 forks source link

HTML & CSS #1

Open kimgoulb opened 7 years ago

kimgoulb commented 7 years ago

Hey Meg!

Sorry for the delay here. Since you have a few commits, I'll make the comments here:

  1. Don't forget to add <meta> tags along with the <title> tags on all pages.
  2. You shouldn't need to put a height on your "icon" style to fix the text flow that happens. Instead you should give the icon and info container a width and float: left.
  3. Remove the display:inline setting you have for the "one-third" and "two-thirds" class. Once you float an element, it ignores that. Also, you need a right:0; on the one-third div, so it sticks to the right of the page.
  4. On "portfolioImg", remove the property "size" that you have set and specify width and height. The browser support for that, is not great.
  5. You can group the styles for "a.prev" since you're targeting the same element.

Overall, great start! 👍

– Kim