This isn't a real issue - feel free to close it whenever you like - I just wanted somewhere I could leave some feedback on the reading material exercises you submitted 🙂
FizzBuzz
Looks great!
FizzBuzzBangBong
Generally looks good, but a couple of small details that could catch you out:
I think you're missing the case that something is divisible by 3, 5 and 7 to print FizzBuzzBang. That doesn't happen within your test range, but still worth considering
On the same one, you could simplify some of your later checks by changing the ordering; let the "Bong" check happen a few lines earlier (or even as the very first check!) so that you don't have to care if a number is divisible by 11 after that
e.g.
if checkFactor(11, num) == 0:
print('Bong ')
elif checkFactor(3, num) == 0 and checkFactor(7, num) == 0:
....
Note that without this, your code will currently go wrong for a number that is divisible by e.g. 3, 7 and 11 since it won't print Bong! Again it's outside your test range, but worth keeping track of anyway
FizzBuzzBangBongFezz
39 prints: "FizFezzz"; I'm not sure your insertions are happening in quite the right fashion!
checkFactors finds all factors, then you always seem to just check if a specific one appears - I'd be inclined to stick to the simpler checkFactors function you had in the previous file
And where you do use the first argument (number of factors) then I'm not sure the logic is quite right; if it had three factors (1, 13 & 19) then we'd still want to just print "Fezz", but this check gets skipped
I think your regex could probably be simplified or even removed - it catches anything with at least one alphabet-character, but couldn't we just use length > 0?
Overall, great effort! If you're curious, one example solution for comparison is available here which should show a slightly simpler approach
Nice, this just worked for me, and looks really clean! The recursive structure for repeatedly asking for a path if an invalid one is provided is particularly nice
This isn't a real issue - feel free to close it whenever you like - I just wanted somewhere I could leave some feedback on the reading material exercises you submitted 🙂
FizzBuzz
FizzBuzzBangBong
Note that without this, your code will currently go wrong for a number that is divisible by e.g. 3, 7 and 11 since it won't print Bong! Again it's outside your test range, but worth keeping track of anyway
FizzBuzzBangBongFezz
Overall, great effort! If you're curious, one example solution for comparison is available here which should show a slightly simpler approach