search

mpusz / mp-units

The quantities and units library for C++
https://mpusz.github.io/mp-units/
MIT License
997 stars 79 forks source link

Enzimology units #481

Closed bourumir-wyngs closed 6 months ago

bourumir-wyngs commented 11 months ago

Here is the proposed extension describing units in enzimology. This is potentially interesting because biochemist most likely will use non-SI units, and there are several varieties used (U vs IU, also katal that is way too large to be practical so nanokatal). I also wrote some unit tests, including static assertions. The knowledge about these units, as seen from googling, is generally widespread but I included that looked for me as a suitable reference. The code builds on my workstation and the tests pass.

bourumir-wyngs commented 10 months ago

I do not understand why GitHub still shows "changes needed". It seems to me that I have already made all proposed. Let me known if I am overlooking something.

mpusz commented 10 months ago

Hi @bourumir-wyngs, are you still working on this one?

mpusz commented 9 months ago

Hi @bourumir-wyngs, did you get my last message? I would like to either finish or close this PR. Please let me know if you still plan to work on it.

mpusz commented 6 months ago

Closing the PR as there have been no updates from the author for several months now.