search

mpusz / mp-units

The quantities and units library for C++
https://mpusz.github.io/mp-units/
MIT License
997 stars 79 forks source link

Floating point classification functions #528

Closed NAThompson closed 6 months ago

NAThompson commented 6 months ago

Add the ability for isnan, isfinite, and isinf to work on dimensioned quantities.

NAThompson commented 6 months ago

@mpusz : Hopefully much less complicated than the last one-this is ready to go.

NAThompson commented 6 months ago

@mpusz : Do you think this-along with the fma work-is big enough to push a new release to conan?

mpusz commented 6 months ago

I do not think that it is big enough and pushing a new release to Conan and Compiler Explorer is not that trivial. For example, we still do not have mp-units 2.1 in Conan because of some CI issues and I did not have time to add it to CE.

I would prefer to wait for a few more changes before we provide another release. Until then you can use our own Conan server to get the latest stable version. Does it work for you?

NAThompson commented 6 months ago

Does it work for you?

@mpusz : Absolutely-my intention is not to increase workload but merely check if something is trivial. Hopefully conan can make this process easier . . .

mpusz commented 6 months ago

It is not that hard at all. I just have to submit short PRs to both ConanCenter and 2 repos from the Compiler Explorer for each new release. If everything works fine (and it should when the V2 design and compiler support will settle down), it should not take too much time. Unfortunately, this is not the case yet.

But you are right. We should release mp-units more often, and I intend to do so.