[WIP] Bugfix: `quantity_cast` fails to compile when provided with a lvalue reference

mpusz / mp-units

The quantities and units library for C++

https://mpusz.github.io/mp-units/

MIT License

994 stars 79 forks source link

[WIP] Bugfix: `quantity_cast` fails to compile when provided with a lvalue reference #569

Closed burnpanck closed 1 month ago

mpusz commented 1 month ago

This bug is really embarrassing. Thanks for finding and fixing it!

mpusz commented 1 month ago

BTW, CMake CI is broken now because the new Conan version is not compatible with the previous one. I have to fix it when I get some time. So do not be surprised by one failing GitHub action.

burnpanck commented 1 month ago

Uh oh, I believe value_cast has the same issue; I'll try to fix that one too