search

mpusz / mp-units

The quantities and units library for C++
https://mpusz.github.io/mp-units/
MIT License
994 stars 79 forks source link

Version bump #575

Closed jbbjarnason closed 1 month ago

jbbjarnason commented 1 month ago

Could you make a version bump since current release v2.1.0 cannot compile with C++23 on gcc14.

Master branch compiles almost fine, it needs add_compile_options(-Wno-subobject-linkage) or fix the relevant code.

mpusz commented 1 month ago

Hi @jbbjarnason, yeah, literally a few minutes ago, I added gcc-14 to our CI. Unfortunately, I still do not have the means to test it as Ubuntu 24.04 is still not available for WSL2 😢

mpusz commented 1 month ago

I also plan to release 2.2 soon. I still need to finish the ISO papers for the St. Louis mailing, fix formatters in the Kalman filter examples, fix the CMake CI when patched Conan is released, and merge #542 (if the CMake is finally fixed as well). So it might take some time.

mpusz commented 1 month ago

But you can submit a PR with a patch for 2.1.0 and I will path the old release then.

mpusz commented 1 month ago

I am nearly done. I got one strange error here: https://github.com/mpusz/mp-units/actions/runs/9112348154/job/25051429027#logs.

jbbjarnason commented 1 month ago

@mpusz same error I got locally, it has something to do with the code that activates when explicit this feature is enabled. If I remember correctly it was line 110 in quantity_spec.h (not at the computer right now so might be wrong on the line number). I did not go any further with it since it was resolved on master branch

mpusz commented 1 month ago

Yes, it is solved on master. Now, I am trying to fix it on 2.1. I am not ready to release 2.2 yet.

mpusz commented 1 month ago

2.1.1 released with gcc-14 and explicit this parameter fixes