search

mpusz / wg21-papers

ISO C++ Committee papers by Mateusz Pusz
https://mpusz.github.io/wg21-papers
4 stars 7 forks source link

Incorporate Michael Hordijk's feedback #64

Closed chiphogg closed 3 months ago

chiphogg commented 3 months ago

Here's an email which I received from Michael:

I just read through a good bit of the quantities and units library proposal. https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2024/p3045r0.html

Some typo/grammatical notes:

8.1

Note: A more detailed graph of the framework’s entities can be found in the Framework entities chapter.

Even though ISO does not officially define these, we find the below terms useful when discussing the domain and its C++ implementation:

9.1.2.1

This reads weird: "Trying to do the same for speed_limit is invalid". I had assumed that it was going to tell me that getting a speed limit in meters was invalid. It took me a few more sentences to figure out what it was talking about. Turns out, getting in meters per second is not value preserving...

13.2.5

Toward the end of the section, in the examples, example to uses PonitOrigin (as opposed to PointOrigin).

I also escaped a dollar sign, because it was messing up the syntax highlighting in my editor. (I verified that it shows up correctly in the rendered doc.)