search

mpv-android / mpv-android

#mpv-android @ libera.chat
MIT License
1.81k stars 226 forks source link

Don't display video in screen cutouts #862

Open zhengqwe opened 3 months ago

zhengqwe commented 3 months ago

Add an option to control whether to display the video in the screen cutout. This will be useful for non-full screen devices.

sfan5 commented 3 months ago

Can you give an example of "non-full screen devices"?

zhengqwe commented 3 months ago

Can you give an example of "non-full screen devices"?

I mean a lot of phones have some component at the top of the screen (like the front camera), in some cases the video image is obscured by them. Cases where components are present on the screen are non-full-screen(The screen is not a complete block). My first language is not English, sorry.

sfan5 commented 3 months ago

So you just mean normal devices with a cutout. I see. I have a phone with a cutout myself and I don't mind the fullscreen playback (though the phone aspect ratio is wider than most video content anyway). mpv-android used to have an option to not display in cutouts but I removed it a while ago due to implementation issues and because I wondered about if anyone was using it.

Not sure what to make of this.

zhengqwe commented 3 months ago

Not sure what to make of this.

bring back the Extend video into the notch/cutout area feature and enable it default.

4lex4 commented 2 months ago

@sfan5

I wondered about if anyone was using it.

Are you kidding? Of course we use that, some devices have the big notch. mpv was great before you removed it for no reason, even vlc added the feature some time ago. It is a mandatory feature for any player on android just not requiring a discussion.

sfan5 commented 2 months ago

As mentioned, it was not removed for no reason. You are welcome to have a try at implementing this feature. Here is the old commit and here is Google's documentation.