search

mpv-android / mpv-android

#mpv-android @ libera.chat
MIT License
1.81k stars 226 forks source link

fullscreen messes up player dialog windows #882

Closed foxjaw closed 2 days ago

foxjaw commented 2 months ago

Important information

Android version: A14

mpv-android version: v0.37.0

Which version of mpv-android introduced the problem (if known): Exists forever

Description

When I select a chapter, the next one gets selected. I suspect the fullscreen as the culprit (hiding of the navigation bar & status bars).

https://github.com/mpv-android/mpv-android/assets/150133625/94e5485a-3b41-4103-88b4-042f86018243

sfan5 commented 1 month ago

Can you suggest where I can find an audio file with this many chapters to reproduce the problem?

foxjaw commented 1 month ago

Oh I used YTDLnis & downloaded a huberman podcast. Any podcast these days contain boatloads of chapters. You can check WAN show from LTT too.

sfan5 commented 1 month ago

Can't reproduce this issue on my Android 14 phone.

mpv-android version: v0.37.0

This is an mpv version number.

foxjaw commented 1 month ago

2023-11-30 / 33 (release)

Did you at least understood what the bug is from above screenshare ?

PS: When the status bar disappears while playback, chapters dialog show weird behaviour where the touch response shifts slightly downwards such that the next one gets selected.

sfan5 commented 1 month ago

Yes, I do. Causing the status bar to show or hide does not produce any weird behavior of the chapter dialog.

foxjaw commented 1 month ago

Strange. I'm on phhusson's GSI but I don't think that would be an issue.

sfan5 commented 1 month ago

I experienced a different but similar layout bug with the playlist dialog and applied a workaround. So c0d41a22a5b3006fad859c2af2174b0f166a76a7 might actually fix your issue too.

foxjaw commented 1 month ago

Could be. Any dialog window that appears on top of the player shows this behavior. Will wait until the next release to test.