search

mpv-android / mpv-android

#mpv-android @ libera.chat
MIT License
1.81k stars 226 forks source link

Unable to add subtitle to video via "open document" (SAF) #897

Closed unnecs closed 1 month ago

unnecs commented 1 month ago

Important information

Android version: 13 mpv-android version: 2024-04-09-release / 8034

Description

Subtitle file won't load when picking it via open document (SAF). While on the other hand, opening a subtitle file via legacy file picker works perfectly.

I would like to be able to rely on SAF exclusively to pick subtitle files (and in the whole app generally) since I think it would greatly reduce potentional future attack surface and vulnerability harm. Also, I think it would somewhat future-proof this feature from newer android versions that might phase legacy file picking.

Thank you for the best android video player <3

sfan5 commented 1 month ago

Please provide a log file so I can diagnose the problem.

Edit: nevermind:

2024-04-14 16:02:31.202 28099-28099 AndroidRuntime          is.xyz.mpv                           E  FATAL EXCEPTION: main
                                                                                                    Process: is.xyz.mpv, PID: 28099
                                                                                                    java.lang.NullPointerException
                                                                                                        at is.xyz.mpv.FilePickerActivity.onDocumentPicked(FilePickerActivity.kt:323)
                                                                                                        at is.xyz.mpv.FilePickerActivity.documentOpener$lambda$1(FilePickerActivity.kt:35)
                                                                                                        at is.xyz.mpv.FilePickerActivity.$r8$lambda$tqrvIo-3qOmi_8QACdkk7Ar0p50(Unknown Source:0)
                                                                                                        at is.xyz.mpv.FilePickerActivity$$ExternalSyntheticLambda7.onActivityResult(D8$$SyntheticClass:0)
                                                                                                        at androidx.activity.result.ActivityResultRegistry$1.onStateChanged(ActivityResultRegistry.java:149)