mpv-android / mpv-android

#mpv-android @ libera.chat
MIT License
1.81k stars 226 forks source link

Make path.sh to dynamically use the NDK version specified in depin… #903

Closed gakramx closed 2 weeks ago

gakramx commented 3 weeks ago

Remove hardcoded NDK version and replaced it with a reference to the version defined in depinfo.sh

sfan5 commented 2 weeks ago

Looks good, can you squash the commits?

gakramx commented 2 weeks ago

Looks good, can you squash the commits?

Sorry i forget this , I squashed 3 commits into one !

syphyr commented 2 weeks ago

I'm not sure why $DIR is needed. All the other scripts just use . ./include/depinfo.sh

sfan5 commented 2 weeks ago

merged as 0fd1e390b9e3bcab54fa60c17e2ccad68dba1a35, thanks.

gakramx commented 2 weeks ago

I'm not sure why $DIR is needed. All the other scripts just use . ./include/depinfo.sh

Using $DIR ensures consistent and reliable sourcing of depinfo.sh, regardless of the script's location.