Failed to update mpv with optional dependencies

mpv-player / homebrew-mpv

☠️ Merged into the main Homebrew repo (was: mpv related formulas for the Homebrew package manager)

http://mpv.io

175 stars 33 forks source link

Failed to update mpv with optional dependencies #73

Closed mrcotter closed 9 years ago

mrcotter commented 9 years ago

The error can be seen as following:

It relates to python version problems. I'm running OS X Yosemite 10.10.5, and python 2 is the build-in version while python 3 is installed by homebrew.

AirPort commented 9 years ago

It probably has something to do with a conflict between https://github.com/Homebrew/homebrew/commit/85271644b0083cbc0fd6fea71120d1ad859fbc2a and the mpv's formula in the repo. For the time being I just manually reverted the python_requirement.rb file to a previous version, but it's quite an unorthodox measure while wating for a real fix.

henry0312 commented 9 years ago

Hello. Can you try master's HEAD?

AirPort commented 9 years ago

That solved the problem on my end. Thank you!

outlyer commented 9 years ago

In regards to @mrcotter saying that "python3 is installed by homebrew," I just want to note that it can be installed by Homebrew, but certainly isn't required and for those of us who are using Homebrew to manage our Python installation's, switching to Python 3.x is a pretty big change.

I was able to build and install mpv after removing all the python3 references from the formula so may I propose that python3 becomes a vapoursynth dependency instead?

i.e. in the formula

if build.with? 'official-libass'
  depends_on :python3
end

and use the default (Homebrew or OSX) python for everyone else?

Argon- commented 9 years ago

Python is not just needed for vapoursynth but also for mpv's build system waf. Or do you propose to not use python3 for building (but e.g. the system python 2.x) unless vapoursynth was specified?

mrcotter commented 9 years ago

Updated formula works fine. Thanks!

However, I encountered another bug yesterday which may come from the newest build of mpv itself. I have to disable hardware decoding when using opengl-hq, otherwise the video output would be nothing but black...

henry0312 commented 9 years ago

That solved the problem on my end. Thank you! https://github.com/mpv-player/homebrew-mpv/issues/73#issuecomment-138984977

Updated formula works fine. Thanks! https://github.com/mpv-player/homebrew-mpv/issues/73#issuecomment-139423754

I'm glad to hear that.

outlyer commented 9 years ago

@Argon- I think that makes sense; most people are still on Python 2.x and unless they explicitly need 3.x for vapoursynth, it'd be better to just use the installed version. But python itself should still be a dependency of course, just not versioned.