search

mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
414 stars 108 forks source link

Missing "" on ffmpeg config #175

Closed s0301132 closed 2 years ago

s0301132 commented 3 years ago

My ffmpeg need to add the following config:

./configure --enable-nvv4l2dec --enable-libv4l2 --enable-shared --extra-libs='-L/usr/lib/aarch64-linux-gnu/tegra -lnvbuf_utils' --extra-cflags='-I /usr/src/jetson_multimedia_api/include/'

However when I build ffmpeg the option is missing "" on Using ffmpeg options: and causing error:

Using ffmpeg options: --enable-gpl --disable-debug --disable-doc --enable-nvv4l2dec --enable-libv4l2 --enable-shared --extra-libs=-L/usr/lib/aarch64-linux-gnu/tegra -lnvbuf_utils --extra-cflags=-I /usr/src/jetson_multimedia_api/include/ --enable-gnutls
Unknown option "-lnvbuf_utils".
See /home/user/Documents/mpv-build/ffmpeg/configure --help for available options.
avih commented 3 years ago

Currently mpv-build doesn't support arguments with spaces or quotes.

You'll need to separate --extra-libs into two values, maybe into --extra-libs=-L/usr/lib/aarch64-linux-gnu/tegra and --extra-libs=-lnvbuf_utils

Also, you don't need the quotes with --extra-cflags, you can do --extra-cflags=-I/usr/src/jetson_multimedia_api/include/

avih commented 2 years ago

Should be fixed now.

See https://github.com/mpv-player/mpv-build/issues/172#issuecomment-983431076