mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
414 stars 108 forks source link

build/configure: allow options with spaces #177

Closed avih closed 2 years ago

avih commented 3 years ago

This PR allows using arguments with spaces:

Where previously none of those were possible.

This addresses #172 and #175

The CLI options fixes are fairly trivial, mainly using quoted "$@" instead of unquoted $@ (build scripts), and at the config scripts - using the positional parameters directly, instead of storing them in a variable for later use (which was expanded unquoted, resulting in loss of spaces).

The main change is the 3rd commit - how the NAME_options files are handled, where previously they were split to individual values based on default IFS (space, tab, newline), thus not allowing arguments with whitespaces, and this PR makes it split using newlines only.

The README was and still is instructing to use one value per line at the NAME_options files, and this remains valid. It was updated to explain how the NAME_options are handled.

@kevmitch thoughts? review?