search

mpv-player / mpv-build

🔨 Helper scripts to compile mpv on Linux
http://mpv.io
403 stars 104 forks source link

debian: add some 'easy' dependencies #202

Closed wsldankers closed 3 months ago

wsldankers commented 1 year ago

Adds dependencies for SDL2, Wayland, libsixel, pipewire, all of which are available in both Debian stable and Ubuntu 22.04 LTS and 24.04 LTS.

Also enables DVB support (which doesn't have any dependencies) and bumps the debhelper compat version to something less archaic.

Dudemanguy commented 1 year ago

Old I know. I would have merged it but according to debian documentation:

The compat 11 is discouraged for new packages as it suffers from feature interaction between dh_installinit and dh_installsystemd causing services to not run correctly in some cases.

That probably doesn't apply to us but maybe we should pick a different number anyways. Not sure if 12 makes the most sense or something even newer. I'll leave that up to you.

wsldankers commented 3 months ago

Old I know. I would have merged it but according to debian documentation:

The compat 11 is discouraged for new packages as it suffers from feature interaction between dh_installinit and dh_installsystemd causing services to not run correctly in some cases.

That probably doesn't apply to us but maybe we should pick a different number anyways. Not sure if 12 makes the most sense or something even newer. I'll leave that up to you.

Yeah, those caveats definitely did not apply to this package. At the time, 11 was the highest version supported by the then-current debian/ubuntu releases I was targeting. Since those versions are now obsolete I changed it to 12 to avoid the discussion.

Dudemanguy commented 3 months ago

Thanks, let's finally pull this in.